Implement copyWith(options) method for the Feature class and add GeoJSON utility functions #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling. - Replace custom implementations with existing specialized modules - Use turf_pip package directly for point-in-polygon checks - Use turf_centroid, turf_midpoint, turf_area and turf_length libraries - Make function non-nullable with proper error handling - Update var to final in benchmark file and across codebase - Update tests to work with geodesic midpoint calculations - Improve documentation and code quality
|
@Newmanjack this PR seems to be labeled wrongly as it contains the code for point on feature, right? |
|
@lukas-h Fixed the files, can be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
1. Utility Functions:
• featureEach: Iterates over features in any GeoJSON object (handles both single Feature and FeatureCollection).
• featureReduce: Reduces features similarly to Iterable. reduce, with special handling for absent initial values (clones the first feature when needed).
2. Feature Extension:
• Added a copyWith method via an extension on the Feature class.
• The method accepts optional parameters (id, properties, geometry, bbox) and returns a new immutable Feature with updated values.
• Includes runtime type checks for new geometry compatibility.
• Documentation and examples have been added for clear, type-safe usage.