refactor: rename second BuildNewListFromBlock variant to RebuildListFromBlock

Rationale:
  - Short and clear
  - The "rebuild" prefix makes it obvious you're starting from an existing list
  - Distinguishes it well from BuildNewListFromBlock (which builds from database)

Author: UdjinM6

src/evo/specialtxman.cpp

@@ -177,10 +177,10 @@ bool CSpecialTxProcessor::BuildNewListFromBlock(const CBlock& block, gsl::not_nu
 {
     AssertLockHeld(cs_main);
     CDeterministicMNList oldList = m_dmnman.GetListForBlock(pindexPrev);
-    return BuildNewListFromBlock(block, pindexPrev, oldList, view, debugLogs, state, mnListRet);
+    return RebuildListFromBlock(block, pindexPrev, oldList, view, debugLogs, state, mnListRet);
 }
 
-bool CSpecialTxProcessor::BuildNewListFromBlock(const CBlock& block, gsl::not_null<const CBlockIndex*> pindexPrev,
+bool CSpecialTxProcessor::RebuildListFromBlock(const CBlock& block, gsl::not_null<const CBlockIndex*> pindexPrev,
                                                 const CDeterministicMNList& prevList, const CCoinsViewCache& view,
                                                 bool debugLogs, BlockValidationState& state,
                                                 CDeterministicMNList& mnListRet)

src/evo/specialtxman.h

@@ -81,7 +81,7 @@ class CSpecialTxProcessor
 
     // Variant that takes an explicit starting list instead of loading from GetListForBlock
     // Used for rebuilding diffs from trusted snapshots
-    bool BuildNewListFromBlock(const CBlock& block, gsl::not_null<const CBlockIndex*> pindexPrev,
+    bool RebuildListFromBlock(const CBlock& block, gsl::not_null<const CBlockIndex*> pindexPrev,
                                const CDeterministicMNList& prevList, const CCoinsViewCache& view, bool debugLogs,
                                BlockValidationState& state, CDeterministicMNList& mnListRet)
         EXCLUSIVE_LOCKS_REQUIRED(cs_main);

src/rpc/evo.cpp

@@ -1808,7 +1808,7 @@ static UniValue evodb_verify_or_repair_impl(const JSONRPCRequest& request, bool
                                            const CDeterministicMNList& prevList, const CCoinsViewCache& view,
                                            bool debugLogs, BlockValidationState& state,
                                            CDeterministicMNList& mnListRet) NO_THREAD_SAFETY_ANALYSIS -> bool {
-        return chain_helper.special_tx->BuildNewListFromBlock(block, pindexPrev, prevList, view, debugLogs, state, mnListRet);
+        return chain_helper.special_tx->RebuildListFromBlock(block, pindexPrev, prevList, view, debugLogs, state, mnListRet);
     };
 
     // Call the dmnman method to do the work