Skip to content

BUG: preserve device for scalars with array input #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2025
Merged

BUG: preserve device for scalars with array input #479

merged 1 commit into from
Oct 14, 2025

Conversation

OmarManzoor
Copy link
Contributor

@OmarManzoor OmarManzoor commented Oct 14, 2025 •
edited
Loading

Fixes #478

  • Allow functions with multiple arrays to allow one of the arguments to be a scalar while the other argument is an array on a device.
  • Modify the asarrays to create the scalar on device when we are dealing with the array API
  • Add a test function within TestIsClose (which was the main function under consideration)

lucascolley
lucascolley approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I guess we already had most of this in place! SGTM, thanks!

@lucascolley lucascolley changed the title ENH allow Python scalars for functions with multiple arrays BUG: preserve device for scalars with array input Oct 14, 2025
@lucascolley lucascolley added the bug Something isn't working label Oct 14, 2025
@lucascolley lucascolley added this to the 0.9.1 milestone Oct 14, 2025
@lucascolley lucascolley merged commit 8f8047b into data-apis:main Oct 14, 2025
11 checks passed
@OmarManzoor OmarManzoor deleted the is_close_device_scalar branch October 14, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucascolley lucascolley lucascolley approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.9.1

Development

Successfully merging this pull request may close these issues.

BUG: isclose: scalars cannot be input alongside non-default device arrays

2 participants

@OmarManzoor @lucascolley