-
Notifications
You must be signed in to change notification settings - Fork 16
ENH: add new function isin
#485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lucascolley I tried adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @OmarManzoor, looks good to me overall! The delegation strategy makes sense to me.
For the failing NumPy 1 tests, probably fine to just skip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @OmarManzoor, looks great!
@all-contributors please add @OmarManzoor for docs, bug, test |
I've put up a pull request to add @OmarManzoor! 🎉 |
@lucascolley Should we add in |
I can't find any discussion about it in the |
Add support for the
isin
functiontowards gh-268