Skip to content

Conversation

OmarManzoor
Copy link
Contributor

@OmarManzoor OmarManzoor commented Oct 15, 2025

Add support for the isin function

towards gh-268

@OmarManzoor
Copy link
Contributor Author

OmarManzoor commented Oct 15, 2025

@lucascolley I tried adding isin. I think there might be adjustments required particularly in the delegation part and also more tests but maybe you could have a look first to see if this generally looks okay.

@lucascolley lucascolley self-requested a review October 15, 2025 08:35
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @OmarManzoor, looks good to me overall! The delegation strategy makes sense to me.

For the failing NumPy 1 tests, probably fine to just skip.

@lucascolley lucascolley added enhancement New feature or request new function labels Oct 15, 2025
@lucascolley lucascolley added this to the 0.9.1 milestone Oct 15, 2025
@lucascolley lucascolley self-requested a review October 16, 2025 17:39
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @OmarManzoor, looks great!

@lucascolley lucascolley changed the title ENH: Add support for isin ENH: add new function isin Oct 17, 2025
@lucascolley lucascolley merged commit cb4e17d into data-apis:main Oct 17, 2025
11 checks passed
@lucascolley
Copy link
Member

@all-contributors please add @OmarManzoor for docs, bug, test

Copy link
Contributor

@lucascolley

I've put up a pull request to add @OmarManzoor! 🎉

@OmarManzoor OmarManzoor deleted the add_isin branch October 17, 2025 11:32
@OmarManzoor
Copy link
Contributor Author

@lucascolley Should we add in fill_diagonal as well?

@lucascolley
Copy link
Member

I can't find any discussion about it in the array-api repo. So yes, probably good to add it here, but could you do some research as to which libraries provide an implementation first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request new function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants