Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: from_dlpack: fix default device #108

Merged
merged 1 commit into from
Dec 11, 2024
Merged

BUG: from_dlpack: fix default device #108

merged 1 commit into from
Dec 11, 2024

Conversation

lucascolley
Copy link
Member

closes gh-99

@lucascolley
Copy link
Member Author

I can confirm that this unblocks SciPy

@lucascolley lucascolley mentioned this pull request Dec 10, 2024
Draft
betatim
betatim reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@betatim betatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick about is vs ==.

We could add an assert to check that the device of x is actually the default device?

We could add a non regression test that uses a numpy array as argument for from_dlpack?

Otherwise looks good to me

@lucascolley
Copy link
Member Author

thanks Tim, addressed

@lucascolley lucascolley requested a review from betatim December 11, 2024 12:31
@betatim betatim merged commit 781a555 into data-apis:main Dec 11, 2024
21 checks passed
@betatim
Copy link
Member

betatim commented Dec 11, 2024

Thanks for the fix and the test!

@lucascolley lucascolley deleted the dlpack-device branch December 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim betatim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrays created with from_dlpack have a different device?
2 participants
@lucascolley @betatim