FIX Use array's device when promoting scalars #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betatim
commented
Oct 21, 2024
| device1 = Device("device1") | ||
| x = asarray([1., 2, 3], device=device1) | ||
|
|
||
| y = x ** 2 |
There was a problem hiding this comment.
Without the change this line would fail, but I felt like having the assert below is somehow useful for readers from the future, even though it isn't strictly necessary
|
@betatim should I make a release with these changes or are there more incoming? |
|
I don't know, maybe lets wait a bit. I've been finding these via running the scikit-learn tests, so far they don't run to completion. But it needs a bit of digging to figure out what the bug is each time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When promoting a scalar in the context of an existing array, e.g.
x ** 2we should use the device ofxfor the array we create.