Skip to content

Conversation

@betatim
Copy link
Member

@betatim betatim commented Oct 31, 2024

This is related to data-apis/array-api#807

This only adds support for scalars to where(). If the second or third argument is a scalar it is turned into an array on the same device as condition.

I added 2024.12 as next_supported_version. This means we can use it in the tests. Not sure if we use some kind of dummy value instead of 2024.12?

@asmeurer
Copy link
Member

asmeurer commented Nov 5, 2024

Some of this overlaps with the stuff I've done over at #82, although I haven't implemented any scalar stuff there yet because it isn't in the standard yet.

Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think it should allow complex x1 and x2, too. Here and in the annotation.

LGTM otherwise!

Copy link
Member

@ev-br ev-br left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict now, could you please resolve it?

Also, the spec requires that at least one of x1 and x2 is an array. IIUC, this PR allows both of them to be python scalars. As long as this repo is scrupulous in implementing the spec, it should probably check and error out if both are scalars?

@ev-br ev-br mentioned this pull request Jan 27, 2025
13 tasks
@ev-br
Copy link
Member

ev-br commented Feb 1, 2025

A small update to make it adhere to the spec to the letter: betatim#1

@betatim
Copy link
Member Author

betatim commented Feb 3, 2025

Thanks for the PR @ev-br If you'd like to take over the original PR (this PR) to get it done that would be awesome.

@ev-br
Copy link
Member

ev-br commented Feb 3, 2025

Happy to oblige @betatim --- thank you!

@ev-br ev-br merged commit 590a2de into data-apis:main Feb 3, 2025
21 checks passed
@betatim betatim deleted the where-with-scalars branch February 3, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants