Add support for scalar arguments to xp.where #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of this overlaps with the stuff I've done over at #82, although I haven't implemented any scalar stuff there yet because it isn't in the standard yet. |
This was referenced Nov 5, 2024
betatim
force-pushed
the
where-with-scalars
branch
from
1b21b2c to
d9a6b73
Compare
ev-br
reviewed
Dec 12, 2024
ev-br
reviewed
Jan 13, 2025
There was a problem hiding this comment.
There's a conflict now, could you please resolve it?
Also, the spec requires that at least one of x1 and x2 is an array. IIUC, this PR allows both of them to be python scalars. As long as this repo is scrupulous in implementing the spec, it should probably check and error out if both are scalars?
11 tasks
|
A small update to make it adhere to the spec to the letter: betatim#1 |
|
Thanks for the PR @ev-br If you'd like to take over the original PR (this PR) to get it done that would be awesome. |
|
Happy to oblige @betatim --- thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to data-apis/array-api#807
This only adds support for scalars to
where(). If the second or third argument is a scalar it is turned into an array on the same device ascondition.I added
2024.12asnext_supported_version. This means we can use it in the tests. Not sure if we use some kind of dummy value instead of 2024.12?