Allow __dlpack__ to work with newer versions of NumPy #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
njzjz
reviewed
Nov 7, 2024
| raise NotImplementedError("The device argument to __dlpack__ is not yet implemented") | ||
| if copy not in [_default, None]: | ||
| raise NotImplementedError("The copy argument to __dlpack__ is not yet implemented") | ||
| if np.__version__[0] < '2.1': |
There was a problem hiding this comment.
This is incorrect:
>>> np.__version__
'2.1.3'
>>> np.__version__[0] < '2.1'
Truenumpy.lib.NumpyVersion can be used here
|
I think I'm going to just drop NumPy 1.x support in a subsequent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85