Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specifications for maximum and minimum #713

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Nov 30, 2023

This PR

  • resolves RFC: add support for computing the element-wise minimum and maximum #667 by adding specifications for computing the element-wise minimum and maximum.
  • as in min and max, complex number support is left unspecified. Input data types should be real-valued data types.
  • as the APIs are straightforward and consistent across array libraries, the changes proposed in this PR do not have any open questions requiring resolution.

@kgryte kgryte added the API extension Adds new functions or objects to the API. label Nov 30, 2023
@kgryte kgryte added this to the v2023 milestone Nov 30, 2023
@kgryte
Copy link
Contributor Author

kgryte commented Dec 14, 2023

As (1) the additions of minimum and maximum have previously been discussed in workgroup meetings and #667, (2) all considered array libraries already implement these element-wise APIs, and (3) no objects have been raised here, will go ahead and merge. Any further changes can be addressed in follow-up PRs.

@kgryte kgryte merged commit 50ca679 into data-apis:main Dec 14, 2023
1 check passed
@kgryte kgryte deleted the feat/minimum-maximum branch December 14, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API extension Adds new functions or objects to the API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add support for computing the element-wise minimum and maximum
1 participant