Skip to content

Conversation

bhardwaj-priyanshu
Copy link
Contributor

@bhardwaj-priyanshu bhardwaj-priyanshu commented Sep 20, 2023

JIRA - PLUGIN-1683

Changes Made:

  • AWS SDK Upgrade: Upgraded the AWS SDK (aws-java-sdk-s3) from version 1.11.133 to 1.12.522

  • Maven Bundle Plugin Upgrade: Upgraded the Maven Bundle Plugin from version 2.5.4 to 3.5.0 as the build failed due to aws-java-sdk-s3 upgrade.

  • Jackson-Databind Exclusion: Removed the exclusion of Jackson-Databind, previously introduced in PR, as the latest version no longer exhibits any vulnerabilities.

  • Explicit Transitive Dependencies:

    • commons-logging:

      • Added version 1.1.1 to resolve conflicts.
      • Conflict arose from hadoop-mapreduce-client-core.
    • httpclient:

      • Added version 4.5.14 to resolve conflicts.
      • Conflict arose from hadoop-common.

Verification

  • E2E tested by creating S3 connection.
  • Verified version override using mvn dependency:tree.

@google-cla
Copy link

google-cla bot commented Sep 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@itsankit-google itsankit-google changed the title Upgrade aws-java-sdk-s3 to 1.12.522, maven-bundle-plugin 3.5.0 [PLUGIN-1683] Upgrade aws-java-sdk-s3 to 1.12.522, maven-bundle-plugin 3.5.0 Sep 20, 2023
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits before merge.

Also do an E2E test after making the changes suggested from the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants