Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump 1.3.1-SNAPSHOT #31

Closed
wants to merge 1 commit into from
Closed

Bump 1.3.1-SNAPSHOT #31

wants to merge 1 commit into from

Conversation

psainics
Copy link
Contributor

Bump the snapshot version to 1.3.1-SNAPSHOT for next SNAPSHOT version !

@psainics psainics force-pushed the release/1.3.1-bump branch from c3595a5 to f2c54ab Compare March 28, 2024 08:52
itsankit-google
itsankit-google reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@itsankit-google itsankit-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be snapshot removal not bump, it was already snapshot, was 1.3.0 already released before?

@psainics
Copy link
Contributor Author

https://github.com/data-integrations/ariba-plugins/tree/release/1.3.0

itsankit-google
itsankit-google reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@itsankit-google itsankit-google left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect release branch names don't contain patch version, please create new release/1.3 branch from this branch.

@itsankit-google
Copy link
Member

Also I don't see the plugin in hub, where was it released?
https://github.com/cdapio/sap-hub/tree/deploy/packages/plugin-ariba

@psainics
Copy link
Contributor Author

I don't have access to the hub, from the commit i thought this was released!

@psainics
Copy link
Contributor Author

This bump is not required we can close this PR,
A new PR (#33) has been raised with correct base !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsankit-google itsankit-google itsankit-google left review comments

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psainics @itsankit-google