Add a flag to check the new metadata api is called for DTS users only #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java
Show resolved
Hide resolved
| this.setUrl(String.format(METADATA_API_URL_TEMPLATE, instanceBaseUrl, tableName)); | ||
| } else if (isSchemaRequired) { |
There was a problem hiding this comment.
what is the difference between metadata api vs schema api?
There was a problem hiding this comment.
metadata api uses column info which in turn is used to create a schema based on value type and schema api provides with the schema based on actual type only.
Schema api was being used earlier
src/main/java/io/cdap/plugin/servicenow/sink/model/SchemaResponseWithoutMetadata.java
Outdated
Show resolved
Hide resolved
|
Reverse the naming convention, let the old schema response and field name class be same and new class can be MetaDataAPISchema and field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the schema changed logic is changed based on the value type being used. Older pipelines are not compatible with this change.
Added a flag, which ensures that for DTS users, schema will be fetched via column metadata api and for CDF users it will be fetched via previous schema api.