Skip to content

Make split size 1000 to resolve api response timeout issue of more than 60 sec #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Make split size 1000 to resolve api response timeout issue of more than 60 sec #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<groupId>io.cdap.plugin</groupId>
<artifactId>servicenow-plugins</artifactId>
<version>1.2.0-SNAPSHOT</version>
<version>1.2.4-SNAPSHOT</version>
<name>ServiceNow Plugins</name>
<packaging>jar</packaging>
<description>Plugins for ServiceNow</description>
Expand Down
36 changes: 22 additions & 14 deletions src/main/java/io/cdap/plugin/servicenow/apiclient/ServiceNowTableAPIClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,22 +127,30 @@ public List<Map<String, String>> fetchTableRecords(
int offset,
int limit)
throws ServiceNowAPIException {
ServiceNowTableAPIRequestBuilder requestBuilder = new ServiceNowTableAPIRequestBuilder(
this.conf.getRestApiEndpoint(), tableName, false)
.setExcludeReferenceLink(true)
.setDisplayValue(valueType)
.setLimit(limit);
List<Map<String, String>> combinedResults = new ArrayList<>();
String accessToken = getAccessToken();
int pageSize = limit / 5;
LOG.info("pageSize:::: " + pageSize);
LOG.info("offset:::: " + offset);
for (int i = 0; i < 5; i++) {
int currentOffset = offset + (i * pageSize);
ServiceNowTableAPIRequestBuilder requestBuilder = new ServiceNowTableAPIRequestBuilder(
this.conf.getRestApiEndpoint(), tableName, false)
.setExcludeReferenceLink(true)
.setDisplayValue(valueType)
.setLimit(pageSize)
.setOffset(currentOffset);
LOG.info("currentOffset:::: " + currentOffset);

applyDateRangeToRequest(requestBuilder, startDate, endDate);

if (offset > 0) {
requestBuilder.setOffset(offset);
requestBuilder.setAuthHeader(accessToken);
RestAPIResponse apiResponse = executeGetWithRetries(requestBuilder.build());
List<Map<String, String>> batch = parseResponseToResultListOfMap(apiResponse.getResponseBody());
combinedResults.addAll(batch);
}

applyDateRangeToRequest(requestBuilder, startDate, endDate);

String accessToken = getAccessToken();
requestBuilder.setAuthHeader(accessToken);
RestAPIResponse apiResponse = executeGetWithRetries(requestBuilder.build());
return parseResponseToResultListOfMap(apiResponse.getResponseBody());
LOG.info("combinedResults size:::: " + combinedResults.size());
return combinedResults;
}

private void applyDateRangeToRequest(ServiceNowTableAPIRequestBuilder requestBuilder, String startDate,
Expand Down