data validation for serviceNow #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitCLI
force-pushed
the
dataValidationServiceNow
branch
2 times, most recently
from
35e2570 to
ed5f4a3
Compare
AnkitCLI
force-pushed
the
dataValidationServiceNow
branch
from
ed5f4a3 to
e37c6e7
Compare
prince-cs
reviewed
Jun 2, 2025
| String columnType = field.getType().toString(); | ||
|
|
||
| switch (columnType) { | ||
|
|
| boolean targetAsBoolean = bigQueryRow.get(columnName).getAsBoolean(); | ||
| Assert.assertEquals("Different values found for column : %s", sourceAsBoolean, targetAsBoolean); | ||
| break; | ||
|
|
| int targetAsInteger = bigQueryRow.get(columnName).getAsInt(); | ||
| Assert.assertEquals("Different values found for column : %s", sourceAsInteger, targetAsInteger); | ||
| break; | ||
|
|
| LocalDateTime targetDateTime = LocalDateTime.parse(bigQueryRow.get(columnName).getAsString()); | ||
| Assert.assertEquals("Different values found for column : %s", sourceDateTime, targetDateTime); | ||
| break; | ||
|
|
| Assert.assertEquals(String.format("Different values found for column: %s", columnName), 0, | ||
| Double.compare(sourceVal, targetVal)); | ||
| break; | ||
|
|
AnkitCLI
force-pushed
the
dataValidationServiceNow
branch
from
e37c6e7 to
b3e4645
Compare
itsankit-google
requested changes
Jun 2, 2025
added for both sink and source |
|
e2e-tests build is failing & branch is out of date with base branch : |
AnkitCLI
force-pushed
the
dataValidationServiceNow
branch
from
f723415 to
64cd3b1
Compare
AnkitCLI
force-pushed
the
dataValidationServiceNow
branch
from
408705a to
4b5336e
Compare
| throws IOException, ServiceNowAPIException { | ||
| BeforeActions.scenario.write("Create new record in Date time table"); | ||
| ServiceNowTableAPIClientImpl tableAPIClient = new ServiceNowTableAPIClientImpl(config.getConnection()); | ||
| String recordDetails = "{'u_date':'2025-05-28 00:00:00','u_datetime':'2025-05-28 15:07:56'}"; |
There was a problem hiding this comment.
this is just testing one format, plan was to test all formats added in https://github.com/data-integrations/servicenow-plugins/pull/88/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes related to fix the data validation logic for service now and bigquery.