[PLUGIN-1856] Error management for Wrangler plugin #726

Amit-CloudSufi · 2025-01-29T08:23:20Z

https://cdap.atlassian.net/browse/PLUGIN-1856

[
  {
    "stageName": "Wrangler",
    "errorCategory": "Plugin-'Wrangler'",
    "errorReason": "Error in stage 'Wrangler'. Format of output schema specified is invalid. Please check the format. com.google.gson.stream.MalformedJsonException: Unterminated object at line 3 column 4 path $.type",
    "errorMessage": "Error in stage 'Wrangler'. Format of output schema specified is invalid. Please check the format. com.google.gson.stream.MalformedJsonException: Unterminated object at line 3 column 4 path $.type",
    "errorType": "USER",
    "dependency": "false"
  }
]

2025-01-30 12:36:48,237 - ERROR [spark-submitter-phase-1-bfc7d018-ded8-11ef-8496-0000009adf90:o.a.s.i.i.SparkHadoopWriter@98] - Aborting job job_202501301236463168859500037448187_0005.
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0) (192.168.1.100 executor driver): org.apache.spark.SparkException: Task failed while writing rows
	at org.apache.spark.internal.io.SparkHadoopWriter$.executeTask(SparkHadoopWriter.scala:163)
	at org.apache.spark.internal.io.SparkHadoopWriter$.$anonfun$write$1(SparkHadoopWriter.scala:88)
	at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:90)
	at org.apache.spark.scheduler.Task.run(Task.scala:136)
	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:548)
	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1504)
	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:551)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
Caused by: java.util.concurrent.ExecutionException: Error when transforming stage Wrangler: com.google.common.util.concurrent.UncheckedExecutionException: io.cdap.cdap.api.exception.WrappedStageException: Stage 'Wrangler' encountered : io.cdap.cdap.api.exception.ProgramFailureException: Error in stage 'Wrangler'. Format of output schema specified is invalid. Please check the format. com.google.gson.stream.MalformedJsonException: Unterminated object at line 3 column 4 path $.type
	at io.cdap.cdap.etl.spark.function.TransformFunction.call(TransformFunction.java:61)
	at org.apache.spark.api.java.JavaRDDLike.$anonfun$flatMap$1(JavaRDDLike.scala:125)
	at scala.collection.Iterator$$anon$11.nextCur(Iterator.scala:486)
	at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:492)
	at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:491)
	at scala.collection.Iterator$$anon$11.hasNext(Iterator.scala:491)
	at org.apache.spark.internal.io.SparkHadoopWriter$.$anonfun$executeTask$1(SparkHadoopWriter.scala:136)
	at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1538)
	at org.apache.spark.internal.io.SparkHadoopWriter$.executeTask(SparkHadoopWriter.scala:135)
	... 9 more

Loading Directive exception:

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java

psainics · 2025-01-29T09:50:52Z

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java

+        String errorMessage = String.format("Precondition '%s' does not result in true or false.",
+            condition);
+        throw WranglerUtil.getProgramFailureExceptionDetailsFromChain(null, errorMessage,
+            ErrorType.USER, false);


I think, user entered the wrong precondition, let me know if you think it can be system error?

why not handle it at WranglerErrorUtil level?

For all DirectiveParseException, DirectiveLoadException, RecipeException & PreconditionException error type can be USER.

At few places, we have System error , that's why have made this method generic. If we put null at error type, by default it will be set to USER in WranglerErrorUtil class.

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

psainics

Please Fix Unit Tests

psainics · 2025-01-29T15:37:20Z

E2E Fixed in #727 !

psainics · 2025-01-30T07:11:34Z

wrangler-transform/src/test/java/io/cdap/wrangler/PreconditionTest.java

@@ -34,7 +35,7 @@ public void testPrecondition() throws Exception {
    Assert.assertEquals(false, new Precondition("false").apply(row));
  }

-  @Test(expected = PreconditionException.class)
+  @Test(expected = ProgramFailureException.class)


Please match error message to verify we are catching the correct error !

done matched

We are still not matching errorMessage, only matching Exception class, this comment is still not resolved.

The above expected = ProgramFailureException is not needed if you are already catching exception in the test.

itsankit-google · 2025-01-30T09:14:23Z

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

-        String.format("Stage:%s - Format of output schema specified is invalid. Please check the format.",
-                      context.getStageName()), e
-      );
+      String errorMessage = String.format("Error in stage '%s'. Format of output schema specified "


please don't use Error in stage anywhere.

stageName is already present in errorCategory.

itsankit-google · 2025-01-30T09:15:39Z

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java

+/**
+ * Util file to handle exceptions caught in Wrangler plugin
+ */
+public class WranglerUtil {


make this class final.

rename it to WranglerErrorUtil

itsankit-google · 2025-01-30T09:16:07Z

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

+          "Error in stage '%s'. Please check the configuration or input data. %s: %s",
+          context.getStageName(), e.getClass().getName(), e.getMessage());
+      throw WranglerUtil.getProgramFailureExceptionDetailsFromChain(e, errorMessage,
+          ErrorType.SYSTEM, false);


why system error?

itsankit-google · 2025-01-31T06:41:15Z

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java

+        if (t instanceof DirectiveLoadException || t instanceof DirectiveParseException
+            || t instanceof RecipeException || t instanceof PreconditionException) {
+          return getProgramFailureException((Exception) t,
+              errorType != null ? errorType : ErrorType.USER, false);


based on exception, there can be different subCategory like Parsing-Directive, Loading-Directive, Executing-Recipe & Precondition

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java

itsankit-google · 2025-01-31T06:44:11Z

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

@@ -276,8 +286,11 @@ && checkPreconditionNotEmpty(false)) {
      }

    } catch (Exception e) {
-      LOG.error(e.getMessage());
-      collector.addFailure("Error occurred : " + e.getMessage(), null).withStacktrace(e.getStackTrace());
+      LOG.error("Error occurred during configuration of the plugin, {}: {}", e.getClass().getName(),


be specific in error message what configuration are we referring to here?

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

itsankit-google

Lots of basic issues in the PR. PTAL, thanks!

itsankit-google

please add evidences/screenshots of all four known exceptions being captured properly in ErrorManagement UI.

Parsing-Directive, Loading-Directive, Executing-Recipe & Precondition

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java

itsankit-google · 2025-02-05T12:01:28Z

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java

      collector.addFailure("Error occurred : " + e.getMessage(), null).withStacktrace(e.getStackTrace());
    }
+


nit: remove empty line

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java

itsankit-google · 2025-02-06T09:33:43Z

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java

+        if (t instanceof DirectiveLoadException) {
+          return getProgramFailureException((DirectiveLoadException) t,
+              errorType != null ? errorType : ErrorType.USER, false, "Loading-Directive");
+        }
+        if (t instanceof DirectiveParseException) {
+          return getProgramFailureException((DirectiveParseException) t,
+              errorType != null ? errorType : ErrorType.USER, false, "Parsing-Directive");
+        }
+        if (t instanceof RecipeException) {
+          return getProgramFailureException((RecipeException) t,
+              errorType != null ? errorType : ErrorType.USER, false, "Executing-Recipe");
+        }
+        if (t instanceof PreconditionException) {
+          return getProgramFailureException((PreconditionException) t,
+              errorType != null ? errorType : ErrorType.USER, false, "Precondition");
+        }


There are few more known exceptions like DirectiveNotFoundException, DirectiveExecutionException

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from df84fa4 to b70d696 Compare January 29, 2025 08:25

Amit-CloudSufi changed the title ~~Error management for Wrangler plugin~~ [PLUGIN-1856] Error management for Wrangler plugin Jan 29, 2025

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from f48259e to 97fa44c Compare January 29, 2025 08:41

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java Outdated Show resolved Hide resolved

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java Outdated Show resolved Hide resolved

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from a54195a to d46f401 Compare January 29, 2025 08:57

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java Outdated Show resolved Hide resolved

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from 335bb68 to 1e04c2d Compare January 29, 2025 09:13

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerUtil.java Outdated Show resolved Hide resolved

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java Outdated Show resolved Hide resolved

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch 2 times, most recently from be7d0f8 to 645593d Compare January 29, 2025 09:35

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java Outdated Show resolved Hide resolved

psainics assigned Amit-CloudSufi Jan 29, 2025

psainics added the build Triggers unit test build label Jan 29, 2025

psainics reviewed Jan 29, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

psainics requested changes Jan 29, 2025

View reviewed changes

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from fa9723f to b7da1fe Compare January 29, 2025 10:01

Amit-CloudSufi requested a review from psainics January 29, 2025 13:40

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from 06a92fa to ff4f0d5 Compare January 29, 2025 18:32

psainics requested a review from itsankit-google January 30, 2025 07:10

psainics reviewed Jan 30, 2025

View reviewed changes

Amit-CloudSufi requested a review from psainics January 30, 2025 08:07

itsankit-google reviewed Jan 30, 2025

View reviewed changes

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Precondition.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google requested changes Jan 31, 2025

View reviewed changes

data-integrations deleted a comment from Amit-CloudSufi Jan 31, 2025

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch 2 times, most recently from f69a84e to 8231144 Compare January 31, 2025 11:17

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Show resolved Hide resolved

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from 877c7c6 to 32f25df Compare January 31, 2025 12:09

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Jan 31, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Show resolved Hide resolved

Amit-CloudSufi requested a review from itsankit-google February 4, 2025 06:38

itsankit-google reviewed Feb 5, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/Wrangler.java Outdated Show resolved Hide resolved

itsankit-google reviewed Feb 5, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java Outdated Show resolved Hide resolved

itsankit-google reviewed Feb 5, 2025

View reviewed changes

wrangler-transform/src/main/java/io/cdap/wrangler/WranglerErrorUtil.java Show resolved Hide resolved

psainics and others added 4 commits February 6, 2025 06:53

Error management for Wrangler Transform plugin

44b2e4e

update

c161bc9

update

02e3cd4

Java doc update

57a3396

Amit-CloudSufi force-pushed the wranglerTransformPlugin branch from e45e426 to 57a3396 Compare February 6, 2025 06:53

Amit-CloudSufi requested a review from itsankit-google February 6, 2025 09:06

itsankit-google reviewed Feb 6, 2025

View reviewed changes

Added few new exception which are wrapped

7156b1a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PLUGIN-1856] Error management for Wrangler plugin #726

[PLUGIN-1856] Error management for Wrangler plugin #726

Amit-CloudSufi commented Jan 29, 2025 •

edited

Loading

psainics Jan 29, 2025

Amit-CloudSufi Jan 29, 2025

itsankit-google Jan 30, 2025

Amit-CloudSufi Jan 30, 2025

psainics left a comment

psainics commented Jan 29, 2025

psainics Jan 30, 2025

Amit-CloudSufi Jan 30, 2025

itsankit-google Jan 30, 2025 •

edited

Loading

itsankit-google Jan 31, 2025

itsankit-google Jan 30, 2025

Amit-CloudSufi Jan 30, 2025

itsankit-google Jan 30, 2025

Amit-CloudSufi Jan 30, 2025

itsankit-google Jan 30, 2025

Amit-CloudSufi Jan 30, 2025

itsankit-google Jan 31, 2025

itsankit-google Jan 31, 2025

itsankit-google left a comment

itsankit-google left a comment •

edited

Loading

itsankit-google Feb 5, 2025

itsankit-google Feb 6, 2025

		collector.addFailure("Error occurred : " + e.getMessage(), null).withStacktrace(e.getStackTrace());
		}

[PLUGIN-1856] Error management for Wrangler plugin #726

Are you sure you want to change the base?

[PLUGIN-1856] Error management for Wrangler plugin #726

Conversation

Amit-CloudSufi commented Jan 29, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

psainics left a comment

Choose a reason for hiding this comment

psainics commented Jan 29, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itsankit-google Jan 30, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itsankit-google left a comment

Choose a reason for hiding this comment

itsankit-google left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Amit-CloudSufi commented Jan 29, 2025 •

edited

Loading

itsankit-google Jan 30, 2025 •

edited

Loading

itsankit-google left a comment •

edited

Loading