[PECOBLR-727] Add kerberos support for proxy auth #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vikrant Puppala <[email protected]>
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
There was a problem hiding this comment.
Pull Request Overview
This PR adds Kerberos support for proxy authentication by refactoring proxy handling logic across multiple HTTP client classes to use shared utilities from a new http_utils module.
Key changes:
- Extracted common proxy detection and connection pool creation logic into shared utilities
- Replaced duplicated proxy handling code in three HTTP client classes with calls to centralized functions
- Standardized proxy authentication handling to support Kerberos (via the shared utility functions)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/databricks/sql/common/unified_http_client.py | Refactored to use shared proxy detection and connection pool creation utilities |
| src/databricks/sql/backend/sea/utils/http_client.py | Replaced custom proxy handling with shared utility functions |
| src/databricks/sql/auth/thrift_http_client.py | Simplified proxy setup by delegating to centralized utilities |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| self._pool_manager = create_connection_pool( | ||
| scheme=self.scheme, | ||
| host=self.realhost if self.using_proxy() else self.host, |
There was a problem hiding this comment.
The method using_proxy() is called but not defined in this class. This will result in an AttributeError when proxy is configured.
Copilot uses AI. Check for mistakes.
| self._pool_manager = create_connection_pool( | ||
| scheme=self.scheme, | ||
| host=self.realhost if self.using_proxy() else self.host, | ||
| port=self.realport if self.using_proxy() else self.port, |
There was a problem hiding this comment.
The method using_proxy() is called but not defined in this class. This will result in an AttributeError when proxy is configured.
Copilot uses AI. Check for mistakes.
| """Initialize the connection pool using shared utility.""" | ||
| self._pool = create_connection_pool( | ||
| scheme=self.scheme, | ||
| host=self.realhost if self.using_proxy() else self.host, |
There was a problem hiding this comment.
The method using_proxy() is called but the original implementation has been removed. This will result in an AttributeError.
Copilot uses AI. Check for mistakes.
| self._pool = create_connection_pool( | ||
| scheme=self.scheme, | ||
| host=self.realhost if self.using_proxy() else self.host, | ||
| port=self.realport if self.using_proxy() else self.port, |
There was a problem hiding this comment.
The method using_proxy() is called but the original implementation has been removed. This will result in an AttributeError.
Copilot uses AI. Check for mistakes.
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
vikrantpuppala
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
vikrantpuppala
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Signed-off-by: Vikrant Puppala <[email protected]>
vikrantpuppala
temporarily deployed
to
azure-prod
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Add kerberos support for proxy auth
How is this tested?
Related Tickets & Documents