Skip to content

fix CAPACITY_FACTOR for moe #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix CAPACITY_FACTOR for moe #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exp/moe/moe_356m_8gpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if [ -n "${3}" ]; then
NUM_EXPERTS=$3;
fi

CAPACITY_FACTOR=16384
CAPACITY_FACTOR=1
if [ -n "${4}" ]; then
CAPACITY_FACTOR=$4;
fi
Expand Down
2 changes: 1 addition & 1 deletion exp/moe/moe_46m_8gpu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if [ -n "${3}" ]; then
NUM_EXPERTS=$3;
fi

CAPACITY_FACTOR=16384
CAPACITY_FACTOR=2
if [ -n "${4}" ]; then
Comment on lines +19 to 20
Copy link
Contributor

@comane comane Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a specific reason of why this is set to 2 rather than 1?

CAPACITY_FACTOR=$4;
fi
Expand Down