Skip to content

Conversation

ronanstokes-db
Copy link
Contributor

Proposed changes

Validate and address issues in serverless using MagicMock to test simulated Databricks serverless environment

Types of changes

What types of changes does your code introduce to dbldatagen?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Change to tutorials, tests or examples
  • Non code change (readme, images or other non-code assets)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules
  • Submission does not reduce code coverage numbers
  • Submission does not increase alerts or messages from prospector / lint

Further comments

@ronanstokes-db ronanstokes-db requested a review from a team as a code owner July 26, 2024 05:14
@ronanstokes-db ronanstokes-db self-assigned this Jul 26, 2024
@ronanstokes-db ronanstokes-db added this to the v0.4.0 Hotfix 1 milestone Jul 26, 2024
@ronanstokes-db ronanstokes-db added the bug Something isn't working label Jul 26, 2024
@ronanstokes-db
Copy link
Contributor Author

Superseded by feature_serverless_support_v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant