Skip to content

Conversation

@radhikaathalye-db
Copy link

Changes

What does this PR do?

Added functionality for uploading the duck db extract to a UC volume

Relevant implementation details

Caveats/things to watch out for when reviewing:

Linked issues

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

✅ 46/46 passed, 5 flaky, 3m13s total

Flaky tests:

  • 🤪 test_validate_mixed_checks (302ms)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (12.681s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (16.431s)
  • 🤪 test_transpile_teradata_sql (18.471s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (5.25s)

Running from acceptance #2825

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.83%. Comparing base (e56851d) to head (7ab23a2).
⚠️ Report is 1 commits behind head on feature/add_local_dashboards.

Files with missing lines Patch % Lines
...bridge/assessments/dashboards/dashboard_manager.py 83.87% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                        @@
##           feature/add_local_dashboards    #2124      +/-   ##
================================================================
+ Coverage                         64.70%   64.83%   +0.12%     
================================================================
  Files                                97       97              
  Lines                              7971     8002      +31     
  Branches                            825      827       +2     
================================================================
+ Hits                               5158     5188      +30     
  Misses                             2634     2634              
- Partials                            179      180       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@goodwillpunning goodwillpunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sundarshankar89
Copy link
Collaborator

LGTM!
@radhikaathalye-db and @goodwillpunning, I made certain changes to the PR This should ideally be a unit test when we mock, so I'm moving the package, can you also make the similar change to original PR?

@gueniai gueniai added the feat/profiler Issues related to profilers label Oct 31, 2025
Copy link
Contributor

@goodwillpunning goodwillpunning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gueniai gueniai merged commit 390f9c7 into feature/add_local_dashboards Oct 31, 2025
10 checks passed
@gueniai gueniai deleted the feature/upload_duckdb_extract_2 branch October 31, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/profiler Issues related to profilers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants