Make action protos private #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekrekr
requested review from
kolina and
Ceridan
and removed request for
a team
Ceridan
reviewed
Feb 19, 2025
core/actions/operation.ts
Outdated
| @@ -323,6 +324,16 @@ export class Operation extends ActionBuilder<dataform.Operation> { | |||
| return dataform.Target.create(this.proto.target); | |||
| } | |||
|
|
|||
| /** @hidden */ | |||
| public getHasOutput() { | |||
There was a problem hiding this comment.
Maybe specify a return type? I assume it is boolean but maybe it is better to make it clear?
There was a problem hiding this comment.
With most methods we just let the return value be implicit, but I'm also a fan of explicitly putting the returned types. Would be good to update everything else too!
There was a problem hiding this comment.
I think we can do it as we go, when touching some code.
Ceridan
approved these changes
Feb 19, 2025
core/actions/test.ts
Outdated
| @@ -137,6 +147,11 @@ export class Test extends ActionBuilder<dataform.Test> { | |||
| return undefined; | |||
| } | |||
|
|
|||
| /** @hidden */ | |||
| public setFilename(filename: string) { | |||
| return (this.proto.fileName = filename); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents proto update logic from happening outside of actions. This makes action update logic more strict by having it happen inside the action files where they are configured.