Separate display logic from execution logic in ExecutionContext #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alamb
force-pushed
the
alamb/split_display
branch
from
bc49ebb to
094f809
Compare
alamb
changed the title
alamb
force-pushed
the
alamb/split_display
branch
from
094f809 to
44857d1
Compare
alamb
commented
Sep 12, 2024
| /// | ||
| /// Error handling: If an error occurs while executing a query, the error is | ||
| /// logged and execution continues | ||
| pub async fn run_sqls(&self, sqls: Vec<&str>, sender: UnboundedSender<AppEvent>) -> Result<()> { |
There was a problem hiding this comment.
I moved the code that executes queries and sends them as AppEvents into its own struct
alamb
commented
Sep 12, 2024
| } | ||
|
|
||
| /// Prints the stream to stdout | ||
| async fn print_stream(&self, mut stream: SendableRecordBatchStream) { |
There was a problem hiding this comment.
I moved the actual calls to println into the cli code
alamb
commented
Sep 12, 2024
| @@ -145,123 +140,44 @@ impl ExecutionContext { | |||
| &self.flightsql_client | |||
| } | |||
|
|
|||
| pub async fn run_sqls(&self, sqls: Vec<&str>, sender: UnboundedSender<AppEvent>) -> Result<()> { | |||
There was a problem hiding this comment.
moved to AppExecution
alamb
commented
Sep 12, 2024
| @@ -42,8 +39,6 @@ use { | |||
| }; | |||
|
|
|||
| use crate::app::config::ExecutionConfig; | |||
| use crate::app::state::tabs::sql::Query; | |||
There was a problem hiding this comment.
the main goal of the PR is to remove these lines from this module
|
I test locally with both the local context and flightsql client and app still works as expected so good to go |
matthewmturner
approved these changes
Sep 12, 2024
|
Thanks @matthewmturner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #132
Follow on to #131
The rationale here is to split out the logic that handles display (e.g.
println!andQueryfrom the actual execution, again so that we can update / test the underyingExecutionContextwithout having the UI affectedThis PR moves the "display" releated logic out of the ExecutionContext and into the app / CLI modules respectively.