Fix TIME processing #236
Merged
Fix TIME processing #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I am not sure whether this logic is worth adding tests for. I hope to consider adding tests some time later this week. |
Instead of assuming we want `Time64Microsecond` when converting from NaiveType, convert based on the interenced type. Update the `get_time*_value` functions to return `NaiveTime` instead of `NaiveDateTime`. Previously they were returning None, because that's what `as_datetime` always returns for Time32 & Time64 values.
sunng87
approved these changes
Nov 18, 2025
Add tests for the `get_time*_value` functions.
Add test for deserialising time parameters, and fix an implementation bug found by the test.
Contributor
Author
|
Tests added now & fixed a bug in my initial changes. I think this is ready to merge now. |
sunng87
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assuming we want
Time64Microsecondwhen converting from NaiveType, convert based on the interenced type.Update the
get_time*_valuefunctions to returnNaiveTimeinstead ofNaiveDateTime. Previously they were returning None, because that's whatas_datetimealways returns for Time32 & Time64 values.