-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingestion) Adding vertexAI ingestion source (v2 - experiment and experiment run) #12836
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared a couple more comments in Slack
name=mock_model.display_name, | ||
description=mock_model.description, | ||
created=TimeStampClass( | ||
time=datetime_to_ts_millis(datetime.fromtimestamp(1647878400)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why go timestamp -> datetime object -> back to timestamp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of re-exporting types in init
files
In general, init files should probably be empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for practical reasons after refactored main script, moved to module.
- ingestion job invocation failed without it
- wanted to avoid redundant import statement, vertexai/vertexai..
Checklist