Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/superset): add timeout values to config to prevent hanging queries from blocking ingestion #12884

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

PeteMango
Copy link
Contributor

Currently, if a request to superset hangs indefinitely, this will stall the entire ingestion pipeline and there are no errors that is currently being surfaced (not even with --debug flag). This aims to prevent that by adding a timeout value to the config file.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@PeteMango PeteMango marked this pull request as ready for review March 14, 2025 19:57
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ingestion/src/datahub/ingestion/source/superset.py 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 14, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Mar 14, 2025
@gabe-lyons
Copy link
Contributor

Are these really all the times we call the superset API? That seems like a surprisingly low amount.

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Mar 17, 2025
@PeteMango
Copy link
Contributor Author

Are these really all the times we call the superset API? That seems like a surprisingly low amount.

Yes, all of the constructions for charts, dashboards and datasets call the paginate_entity_api_results function, which means we only had to change it in one place. Only datasets require specific dataset info which is why we also updated get_dataset_info

@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants