-
Notifications
You must be signed in to change notification settings - Fork 3.3k
feat(ui/ingest): unity-catalog => databricks #14636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 128 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
|
✅ Meticulous spotted 0 visual differences across 994 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit b80d6cc. This comment will update as new commits are pushed. |
a4dad01 to
5f1af77
Compare
5f1af77 to
6f8cbe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me! I guess we already did the rename on the python side. One request before approval
|
|
||
| const DEFAULT_PAGE_SIZE = 25; | ||
|
|
||
| const mapSourceTypeAliases = (source) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a type annotation here, both for source and return type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Added the annotation to both sites:
const mapSourceTypeAliases <T extends { type: string }>(source?: T): T | undefined = {
datahub-web-react/src/app/ingestV2/source/IngestionSourceList.tsx
Outdated
Show resolved
Hide resolved
6f8cbe2 to
2f981b2
Compare
|
@asikowitz bump |
|
@asikowitz could you take another look when you get a chance, please? |
2f981b2 to
c5a34ef
Compare
c5a34ef to
bd90102
Compare
- Change newly-creted Databricks recipes to have `type: databricks` - Support visual RecipeForm for both `databricks` and `unity-catalog` (including platform name and link to documentation at the top).
bd90102 to
b80d6cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay here
type: databrickstype: databricksdatabricksandunity-catalog(including platform name and link to documentation at the top)