Skip to content

Conversation

@ligfx
Copy link
Contributor

@ligfx ligfx commented Sep 2, 2025

  • Change newly-created Databricks recipes to have type: databricks
  • Change Databricks example recipes in documentation to have type: databricks
  • Support visual RecipeForm for both databricks and unity-catalog (including platform name and link to documentation at the top)

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX labels Sep 2, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Sep 2, 2025
@codecov
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Sep 2, 2025

Bundle Report

Changes will increase total bundle size by 128 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.59MB 128 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 128 bytes 18.93MB 0.0%

Files in assets/index-*.js:

  • ./src/app/ingest/source/builder/sources.json → Total Size: 34.35kB

  • ./src/app/ingestV2/source/builder/RecipeForm/constants.ts → Total Size: 9.65kB

  • ./src/app/ingest/source/IngestionSourceList.tsx → Total Size: 15.76kB

  • ./src/app/ingest/source/builder/RecipeForm/constants.ts → Total Size: 11.01kB

  • ./src/app/ingestV2/source/builder/sources.json → Total Size: 33.51kB

  • ./src/app/ingestV2/source/IngestionSourceList.tsx → Total Size: 21.36kB

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 2, 2025

✅ Meticulous spotted 0 visual differences across 994 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit b80d6cc. This comment will update as new commits are pushed.

Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me! I guess we already did the rename on the python side. One request before approval


const DEFAULT_PAGE_SIZE = 25;

const mapSourceTypeAliases = (source) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a type annotation here, both for source and return type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Added the annotation to both sites:

const mapSourceTypeAliases <T extends { type: string }>(source?: T): T | undefined = {

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Sep 3, 2025
@ligfx ligfx force-pushed the mm--ingestion-ui-default-databricks branch from 6f8cbe2 to 2f981b2 Compare September 3, 2025 12:52
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Sep 3, 2025
@ligfx
Copy link
Contributor Author

ligfx commented Sep 8, 2025

@asikowitz bump

@ligfx
Copy link
Contributor Author

ligfx commented Sep 17, 2025

@asikowitz could you take another look when you get a chance, please?

ligfx added 3 commits October 15, 2025 09:48
- Change newly-creted Databricks recipes to have `type: databricks`
- Support visual RecipeForm for both `databricks` and `unity-catalog` (including
  platform name and link to documentation at the top).
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay here

@asikowitz asikowitz merged commit b4b96ab into master Oct 20, 2025
60 checks passed
@asikowitz asikowitz deleted the mm--ingestion-ui-default-databricks branch October 20, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata needs-review Label for PRs that need review from a maintainer. product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants