Skip to content

Conversation

@chriscollins3456
Copy link
Collaborator

Fixes a minor situation on the schema table with the markdown viewer where we can have "View more" all at different locations depending on the width of the full content. Now, always have the markdown viewer just take up all of its given space.

Before:
Screenshot 2025-09-03 at 11 45 18 AM

After
Screenshot 2025-09-03 at 11 45 44 AM

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 3, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 3, 2025

✅ Meticulous spotted visual differences in 28 of 1380 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit df8dab2. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Sep 3, 2025

Bundle Report

Changes will increase total bundle size by 46 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.56MB 46 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 46 bytes 18.91MB 0.0%

Files in assets/index-*.js:

  • ./src/app/entityV2/shared/tabs/Documentation/components/CompactMarkdownViewer.tsx → Total Size: 3.58kB

  • ./src/app/entityV2/dataset/profile/schema/components/SchemaDescriptionField.tsx → Total Size: 5.23kB

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@chriscollins3456 chriscollins3456 merged commit f8a401d into master Sep 15, 2025
35 checks passed
@chriscollins3456 chriscollins3456 deleted the cc--ch-1599-schema-table-indents branch September 15, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants