Skip to content

fix(docs): update usage_stats optionality #14659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(docs): update usage_stats optionality #14659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
152e5f7
fix(docs): update usage_stats optionality
kevinkarchacryl Sep 3, 2025
b852a76
Merge branch 'master' into redshift-docs-query-usage
kevinkarchacryl Sep 4, 2025
718bcdf
Merge branch 'master' into redshift-docs-query-usage
kevinkarchacryl Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata-ingestion/docs/sources/redshift/redshift_pre.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ shows up correctly after datashare consumer namespace is ingested.

### Profiling

Profiling runs sql queries on the redshift cluster to get statistics about the tables. To be able to do that, the user needs to have read access to the tables that should be profiled.
Profiling runs sql queries on the redshift cluster to get statistics about the tables. In order to do that, the user needs to have read access on the tables that should be profiled.
Copy link
Contributor Author

@kevinkarchacryl kevinkarchacryl Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't needed, I was just making sure that changes were going to this page https://docs-website-dg2mt4evv-acryldata.vercel.app/docs/generated/ingestion/sources/redshift/


If you don't want to grant read access to the tables you can enable table level profiling which will get table statistics without reading the data.

Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/redshift/redshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
@capability(SourceCapability.SCHEMA_METADATA, "Enabled by default")
@capability(
SourceCapability.USAGE_STATS,
"Enabled by default, can be disabled via configuration `include_usage_statistics`",
"Optionally enabled via `include_usage_statistics`",
Copy link
Contributor Author

@kevinkarchacryl kevinkarchacryl Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not show up on https://docs-website-dg2mt4evv-acryldata.vercel.app/docs/generated/ingestion/sources/redshift/

)
@capability(
SourceCapability.DELETION_DETECTION, "Enabled by default via stateful ingestion"
Expand Down
Loading