feat(policies): Add a new default policy for viewing "public" entity types. #14669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devops
… into jj--add-non-editable-view-policy
jjoyce0510
changed the title
datahub-cyborg
bot
added
the
needs-review
gabe-lyons
approved these changes
Sep 4, 2025
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
pedro93
reviewed
Sep 4, 2025
Collaborator
pedro93
left a comment
pedro93
left a comment
There was a problem hiding this comment.
Please add documentation around this. We need to educate users on how to use and model policies correctly.
Collaborator
Author
|
This is not end user facing. This is "good defaults" that need to be there to avoid confusing users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is: Currently we have a default, but editable policy that grants all users to view all entity types.
However, often times admin users will disable this policy to restrict access to specific assets, domains, or glossary.
This however, disables user's ability to see entity types that really should be considered "public", making some features feel broken.
This PR introduces a new NON-EDITABLE policy that enables all users to view "public" entity types. This will prevent customers from shooting themselves in the foot by disabling other default policies.
Thanks to @acrylJonny for pointing this out!