Skip to content

Conversation

@jayacryl
Copy link
Collaborator

@jayacryl jayacryl commented Sep 4, 2025

No description provided.

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 4, 2025

✅ Meticulous spotted visual differences in 156 of 1534 screens tested, but all differences have already been approved: view differences detected.

Meticulous evaluated ~8 hours of user flows against your PR.

Last updated for commit b206df5. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Bundle Report

Changes will increase total bundle size by 2.3kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.56MB 2.3kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 2.3kB 18.91MB 0.01%

Files in assets/index-*.js:

  • ./src/app/entity/shared/tabs/Incident/IncidentTab.tsx → Total Size: 3.49kB

  • ./src/app/entity/shared/tabs/Incident/incidentUtils.ts → Total Size: 3.04kB

  • ./src/app/entityV2/shared/tabs/Incident/utils.tsx → Total Size: 14.18kB

  • ./src/app/entityV2/shared/tabs/Incident/incidentUtils.ts → Total Size: 2.32kB

  • ./src/app/entity/shared/tabs/Incident/components/IncidentListItem.tsx → Total Size: 9.41kB

  • ./src/app/entityV2/shared/tabs/Incident/AcrylComponents/hooks/useIncidentHandler.ts → Total Size: 5.25kB

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...cident/AcrylComponents/hooks/useIncidentHandler.ts 0.00% 18 Missing ⚠️
...com/linkedin/datahub/graphql/GmsGraphQLEngine.java 0.00% 5 Missing ⚠️
...c/app/entity/shared/tabs/Incident/incidentUtils.ts 0.00% 1 Missing ⚠️
...app/entityV2/shared/tabs/Incident/incidentUtils.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (3.84%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@@ -1,3 +1,5 @@
#import "./incident.graphql"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

"filterNameOverride": "Priority"
}
priority: optional int = 0
priority: optional int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a potentially backward incompatible change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bug, nobody would want this to default like this. It's optional anyways so not breaking anything

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Sep 5, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Sep 9, 2025
@jayacryl jayacryl merged commit d67681b into master Sep 10, 2025
81 of 84 checks passed
@jayacryl jayacryl deleted the jp--incidents-apis branch September 10, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants