Skip to content

Conversation

@sakethvarma397
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Sep 4, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Sep 4, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 4, 2025

🔴 Meticulous spotted visual differences in 20 of 1435 screens tested: view and approve differences detected.

Meticulous evaluated ~9 hours of user flows against your PR.

Last updated for commit 857d9ba. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Sep 4, 2025

Bundle Report

Changes will increase total bundle size by 670 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.55MB 670 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 670 bytes 18.9MB 0.0%

Files in assets/index-*.js:

  • ./src/app/previewV2/DefaultPreviewCard.tsx → Total Size: 9.87kB

  • ./src/app/entityV2/application/ApplicationEntitiesTab.tsx → Total Size: 556 bytes

  • ./src/app/previewV2/utils.ts → Total Size: 5.44kB

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 19.44444% with 29 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
datahub-web-react/src/app/previewV2/utils.ts 19.44% 29 Missing ⚠️

❌ Your patch status has failed because the patch coverage (19.44%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Sep 9, 2025
@sakethvarma397 sakethvarma397 merged commit c7ad3f4 into master Sep 9, 2025
34 of 36 checks passed
@sakethvarma397 sakethvarma397 deleted the sv--cus-5867-remove-asset-from-application branch September 9, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants