feat(files) Add basic file cleanup after related entity is deleted #15271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic S3 file cleanup when the asset that a file is created for/references is deleted. This makes sense today as we only support uploading files in asset documentation, and we use that asset that the file is uploaded to to check permissions for whether a user can view the file that was uploaded or not. So if that asset is deleted, we should also remove the file.
This implementation may change in the future as we extend this file upload feature to more surface areas of the app, but for now I wanted a basic version of it checked in.