feat : Fallback to bucketAuto Strategy In Monngodb #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash-data
reviewed
Mar 20, 2025
hash-data
reviewed
Mar 23, 2025
hash-data
changed the title
drivers/mongodb/internal/backfill.go
Outdated
| return chunks, nil | ||
| } | ||
|
|
||
| switch m.config.PartitionStrategy { | ||
| case "timestamp": | ||
| return timestampStrategy() | ||
| default: | ||
| return splitVectorStrategy() | ||
| chunks, err := splitVectorStrategy() | ||
| if err != nil { |
There was a problem hiding this comment.
this can fail even if some network error happened.
There was a problem hiding this comment.
we need to specifically check for split vector not supported kind of log
shubham19may
previously approved these changes
Mar 24, 2025
hash-data
force-pushed
the
feat/atlas-splitvector-fallback
branch
from
47d371a to
4f987ff
Compare
shubham19may
approved these changes
Mar 24, 2025
hash-data
force-pushed
the
feat/atlas-splitvector-fallback
branch
from
4f987ff to
a1de349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a fallback to the bucketAuto strategy when the splitVector strategy encounters issues in Atlas environments.
Fixes # (issue)
Type of change
How Has This Been Tested?
Screenshots or Recordings
Related PR's (If Any):