Fixes #50 (Handle Deleted documents (Good First Issue)) #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hash-data
reviewed
Feb 6, 2025
| var documentToProcess map[string]any | ||
| switch record.OperationType { | ||
| case "delete": | ||
| documentToProcess = map[string]any{ |
There was a problem hiding this comment.
document to process will only contain id (id of deleted object) in case of delete.
|
|
||
| if documentToProcess != nil { | ||
| handleObjectID(documentToProcess) | ||
| rawRecord := types.CreateRawRecord(utils.GetKeysHash(documentToProcess, constants.MongoPrimaryID), documentToProcess, 0) |
There was a problem hiding this comment.
here, the last argument of CreateRawRecord takes the delete timestamp which can be taken from CDC delete metadata.
|
@kuldeep27396 can you please update here? |
|
@kuldeep27396 closing this as its stale, and already being implemented as a part of iceberg writer. |
|
Sure, Thanks..Will try to check another issues when I find some time..
…On Sat, Mar 22, 2025 at 3:45 PM Shubham Baldava ***@***.***> wrote:
@kuldeep27396 <https://github.com/kuldeep27396> closing this as its
stale, and already being implemented as a part of iceberg writer.
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOXQDBTG3AUAR7KQSIJRC3T2VUZ5HAVCNFSM6AAAAABWJIGNECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGE4TMNZZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: shubham19may]*shubham19may* left a comment (datazip-inc/olake#80)
<#80 (comment)>
@kuldeep27396 <https://github.com/kuldeep27396> closing this as its
stale, and already being implemented as a part of iceberg writer.
—
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOXQDBTG3AUAR7KQSIJRC3T2VUZ5HAVCNFSM6AAAAABWJIGNECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGE4TMNZZGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements proper handling of deleted documents in MongoDB Change Data Capture (CDC). Previously, the system only handled insert and update operations while skipping delete operations. The implementation now properly captures and processes delete operations in the CDC stream, including metadata such as deletion timestamp and namespace information.
Fixes #50 (Handle Deleted documents (Good First Issue))
Type of change
How Has This Been Tested?
NA
Screenshots or Recordings
N/A - Backend changes only
Related PR's:
#51
Key Changes: