#2025: Add check to ensure files end in .json

companies/autoscout24.json

@@ -6,7 +6,7 @@
         "insurance"
     ],
     "name": "AutoScout24 GmbH",
-    "address": "Bothestraße 11 – 15\n81675 München\nDeutschland",
+    "address": "Bothestraße 11 – 15\n81675 München\nDeutschland",
     "phone": "+49 89 444 56 1666",
     "email": "[email protected]",
     "web": "https://www.autoscout24.de/",

companies/moebel-boss.json

@@ -7,7 +7,7 @@
         "commerce"
     ],
     "name": "SB-Möbel Boss Handelsgesellschaft mbH & Co. KG",
-    "address": "Bakenweg 16 – 20\n32457 Porta Westfalica\nDeutschland",
+    "address": "Bakenweg 16 – 20\n32457 Porta Westfalica\nDeutschland",
     "phone": "+49 5731 609 0",
     "fax": "+49 5731 609 588",
     "email": "[email protected]",

companies/prettylittlething.json

@@ -7,7 +7,7 @@
         "commerce"
     ],
     "name": "Prettylittlething.com Ltd.",
-    "address": "49 – 51 Dale Street\nManchester\nM1 2HF\nUnited Kingdom",
+    "address": "49 – 51 Dale Street\nManchester\nM1 2HF\nUnited Kingdom",
     "email": "[email protected]",
     "web": "https://www.prettylittlething.com",
     "sources": [

companies/soundcloud.json

@@ -11,7 +11,7 @@
         "SoundCloud Go+",
         "SoundCloud Inc."
     ],
-    "address": "Rheinsberger Straße 76 – 77\n10115 Berlin\nDeutschland",
+    "address": "Rheinsberger Straße 76 – 77\n10115 Berlin\nDeutschland",
     "phone": "+49 30 467 247 600",
     "email": "[email protected]",
     "web": "https://soundcloud.com/",

src/checks/generic/json-file-extension.ts

@@ -0,0 +1,22 @@
+import { basename, extname } from 'path';
+import { exit } from 'process';
+import { Check } from '../../types/checks';
+
+const check: Check = {
+    id: 'json-file-extension',
+    desc: 'Data files should end with `.json` (#2025)',
+    url: 'https://github.com/datenanfragen/data/#data-formats',
+    severity: 'ERROR',
+    run: (json, ctx) => {
+        const filename = basename(ctx.file_path); 
+        const file_extension = extname(ctx.file_path)
+
+        if (file_extension != ".json")
+            return {
+                message: `File \`${filename}\` should end in .json. Please rename the file.`,
+                location: { start: { line: 1 } },
+                suggestions: [basename(filename, file_extension) + '.json'],
+            };
+    },
+};
+export default check;

src/checks/index.ts

@@ -32,6 +32,11 @@ const linters = async () => {
             url: 'https://github.com/datenanfragen/data/blob/master/src/checks/pack',
             path_filter: (path: string) => path.startsWith('company-packs/'),
         },
+        genericlint: {
+            checks: await importChecks('generic'),
+            url: 'https://github.com/datenanfragen/data/blob/master/src/checks/generic',
+            path_filter: (path: string) => path.startsWith('companies/') || path.startsWith('company-packs/') || path.startsWith('supervisory-authorities/') || path.startsWith('suggested-companies/'),
+        },
     };
 };
 export default linters;

src/checks/record/match-filename-slug.ts

@@ -7,8 +7,8 @@ const check: Check = {
     url: 'https://github.com/datenanfragen/data/#data-formats',
     severity: 'ERROR',
     run: (json, ctx) => {
-        const filename = basename(ctx.file_path);
-        if (json.slug + '.json' !== filename)
+        const filename = basename(ctx.file_path, '.json'); 
+        if (json.slug !== filename)
             return {
                 message: `Filename \`${filename}\` does not match slug \`${json.slug}\`.
 

src/test-records.ts

@@ -37,7 +37,7 @@ const validate = async (dir: string) => {
     const check_results: RdjsonLine[] = [];
 
     const linters = await _linters();
-    const files = glob.sync(`${dir}/*.json`);
+    const files = glob.sync(`${dir}/*`);
 
     for (const f of files) {
         const file_content = fs.readFileSync(f).toString();

supervisory-authorities/grdpa.json

@@ -4,7 +4,7 @@
         "gr"
     ],
     "name": "Αρχή Προστασίας Δεδομένων Προσωπικού Χαρακτήρα (Hellenic Data Protection Authority)",
-    "address": "Kifissias 1 – 3\n115 23 Athens\nGreece",
+    "address": "Kifissias 1 – 3\n115 23 Athens\nGreece",
     "phone": "+30 210 64756 00",
     "fax": "+30 210 64756 28",
     "email": "[email protected]",