fix(install): tell users which folder to open their chat app in - #422
Merged
Conversation
The one-line installer is documented as a Terminal command, so the "Next steps" block is read by someone with no chat app open yet. It said "In Claude Code chat, type: /setup" without saying where to open Claude Code — and opening it somewhere other than the folder you just installed into is the mistake people actually make. Adds one step naming the folder. App detection itself is unchanged. Tests gain a chat_app shim so the detected-app path can be exercised, plus assertions that detection names one app only and never leaks the other.
What this pull request touches
Gates that will judge this change
Based on 2 changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One extra step in the installer's closing output:
App detection (
Claude Code/Cursor/your AI app) is unchanged — that landed inb45c3755.Why
The documented install path is a Terminal one-liner:
So this text is read by someone sitting in a terminal with no chat app open.
maincurrently says "In Claude Code chat, type: /setup" without saying where to open Claude Code, and opening it somewhere other than the freshly installed folder is the mistake people actually make — the chat then can't see any of Dex's files.What this deliberately does not say
An earlier draft told users to "start a new chat" because "a new chat loads Dex's MCP servers". That was dropped:
/setupworks fine in an already-open session, so it added a step most people don't need and gave a reason that isn't the real one. This PR only tells them where, not to restart anything.Tests
core/tests/test_install_convergence.py— 7 passed (5 existing, 2 new).The fixture gains an optional
chat_appshim so the detected-app path is exercisable at all, which it wasn't before. Both new tests also assert detection names one app only and never leaks the other.Notes
mainbecause it carried a parallel implementation of app detection already merged asb45c3755. This branch is built directly onmainand touches only the closing output./dex-push.