Skip to content

Troubleshooting home for /dex-doctor and /feedback (rebased remainder) - #432

Merged
davekilleen merged 2 commits into
mainfrom
feat/feedback-awareness-remainder
Aug 12, 2026
Merged

Troubleshooting home for /dex-doctor and /feedback (rebased remainder)#432
davekilleen merged 2 commits into
mainfrom
feat/feedback-awareness-remainder

Conversation

@davekilleen

@davekilleen davekilleen commented Aug 8, 2026

Copy link
Copy Markdown
Owner

⚠️ Holding for review — do not merge

Rebased onto current main and reconciled against everything that shipped since it was opened on Aug 8. Was conflicting; now clean. Recommendation: merge the remainder (details below), but holding per the Front Desk.

What changed in this reconciliation

This PR predated three things that have since shipped, so it has been split: the superseded half is dropped, the still-valuable half is kept and brought up to date.

Dropped as superseded (1 of 6 changes)

Original change Why it's gone
.claude/flows/onboarding.md — add /dex-doctor to the completion-message beat Fully superseded by #454, which gave feedback and Doctor a dedicated education beat at the end of Step 10, and reduced the Step 11 line to a short callback. The line this PR edited no longer exists in that form. Rebasing it would have re-introduced older copy.

Kept — genuinely not done anywhere else (5 of 6)

Verified against current main before keeping: Dex_System_Guide.md, README.md and Dex_Technical_Guide.md contain zero mentions of /feedback today. Workstream 4 of the feedback-loop-launch-awareness card is real and still open.

  • 06-Resources/Dex_System/Dex_System_Guide.md — the canonical "Troubleshooting: When Something Seems Broken" passage.
  • README.md — pointer in the setup-troubleshooting block, for "something broke after setup".
  • 06-Resources/Dex_System/Dex_Technical_Guide.md — pointer from the Doctor testing section.
  • .claude/skills/dex-doctor/SKILL.md/feedback in Related Commands (the skill body already invokes it twice; the list didn't mention it).
  • .claude/skills/getting-started/SKILL.md — a /dex-doctor discovery bullet. Its /feedback bullet was improved separately since Aug 8, so the merge keeps the newer bullet rather than reverting it.
  • docs/Dex_System/ mirrors kept byte-identical, as test_docs_bridge.py requires.

Brought up to date (new commit)

The Aug 8 copy is factually behind v1.94.0:

  1. It told users to run a command or say "report this." Since Recognise a bug from ordinary wording, not just the magic words #455 shipped, ordinary descriptions route to the same place, so the guides now say what's true: describe it however you like, with /feedback as the explicit alternative.
  2. Both help pages now exist, so the passages link them (help/feedback.html, help/updating-troubleshooting.html#health-dex-doctor) instead of describing them. Both verified 200 with anchors present.
  3. Two claims tightened. Doctor now "repairs what it can on its own without touching your notes" rather than "fixes what's safe" — this repo deliberately avoids calling things safe in user copy about what a tool may touch. And reports "by default wait for your yes" rather than promising unqualified show-before-send, which isn't true for users who explicitly opted into auto-send.
  4. The Technical Guide now records that the persona trigger block is a second route into /feedback, and that setup problems route back to Doctor.

Verified

  • 175 passed: test_docs_bridge.py (mirror equality), test_skill_integrity.py, test_instruction_honesty.py, test_feedback_trigger_routing.py
  • Gates green locally: founder-content, PII, doc-drift, instructed-tools, architecture-inventory
  • Original author's commit preserved by cherry-pick rather than rewritten; the reconciliation is a separate commit on top

No changelog entry: guide and README copy only, no behaviour change. The behaviour it documents already shipped in 1.93.1–1.93.3 / v1.94.0.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

What this pull request touches

  • skills — feeds the guided workflows and commands people use with Dex.

Gates that will judge this change

  • Personal-data gate: added lines must not expose real identities or personal vault content.
  • Change-aware gates: source changes are checked for tests, path-contract use, documentation drift, and touched-file coverage.
  • Tests and coverage: the Python, MCP, migration, hook, and script suites must remain healthy.
  • Safety and quality: security, lint, distribution, path consistency, and large-vault checks still apply.

Based on 7 changed files.

davekilleen and others added 2 commits August 12, 2026 00:20
…tor's onboarding moment

Remaining scope of the feedback-loop-launch-awareness card (PR #431 covered
onboarding /feedback intro and post-update announcements):

- Canonical troubleshooting passage in Dex_System_Guide.md (Vault Health
  section): /dex-doctor as first stop when something seems broken, /feedback
  when it's a genuine Dex bug — with the privacy promise spelled out.
- Brief pointers: README setup-troubleshooting block, Dex_Technical_Guide's
  Testing Doctor section, and dex-doctor SKILL.md Related Commands.
- Doctor's onboarding moment: the completion message's 'if anything ever
  feels broken' beat now introduces /dex-doctor before /feedback, and the
  getting-started completion list gains a /dex-doctor bullet.
- docs/Dex_System copies kept byte-identical to 06-Resources sources.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The original commit was written on Aug 8. Three things have shipped since
that change what this copy should say:

- Onboarding now has its own feedback + Doctor beat (#454), so the
  onboarding hunk from the original commit is dropped entirely rather
  than rebased — it edited a line that no longer exists in that form.
- Casual wording now routes to the feedback packager (#455, v1.94.0), so
  the guides no longer tell people to run a command or say a magic phrase.
  They say what is now true: describe it however you like.
- The help pages for both surfaces are live and verified, so the passages
  link them instead of describing them.

Also tightened two claims: Doctor "repairs what it can on its own without
touching your notes" rather than "fixes what's safe" (safe is a word this
repo deliberately avoids in user copy about what a tool may touch), and
reports "by default wait for your yes" rather than an unqualified promise
that everything is always shown, which is not true for users who have
explicitly opted into auto-send.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@davekilleen
davekilleen force-pushed the feat/feedback-awareness-remainder branch from 73d43db to 722b210 Compare August 12, 2026 00:22
@davekilleen davekilleen changed the title Troubleshooting home for /dex-doctor + /feedback, and Doctor's onboarding moment Troubleshooting home for /dex-doctor and /feedback (rebased remainder) Aug 12, 2026
@davekilleen
davekilleen merged commit 2bef8ee into main Aug 12, 2026
9 checks passed
@davekilleen
davekilleen deleted the feat/feedback-awareness-remainder branch August 12, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant