fix(script): Configure all switches in the loop #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration logic was incorrectly indented outside the main loop, which resulted in only the last switch being configured. This commit moves the configuration commands inside the loop to ensure each switch is configured sequentially. It also updates the script to Python 3, adds basic error handling for the Telnet connection, and includes a command to save the running configuration. Fixes davidbombal#14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration logic was incorrectly indented outside the main loop, which resulted in only the last switch being configured.
This commit moves the configuration commands inside the loop to ensure each switch is configured sequentially. It also updates the script to Python 3, adds basic error handling for the Telnet connection, and includes a command to save the running configuration.
Fixes #14
Closes #14