test: e2e coverage for PR #35 (default search mode) and PR #36 (summary removed) - #37
Merged
Merged
Conversation
…ary removed) - TestDefaultSearchMode: verifies kb_search with no mode arg resolves to requested_mode='hybrid' (PR #35 default), and explicit fts/hybrid are echoed correctly in requested_mode - TestSummaryModeRemoved: verifies search_mode='summary' raises LoreClientError now that Literal["summary"] is dropped from the enum (PR #36) All 4 tests pass against lore-staging (http://localhost:5556 on CT 200). 17/17 pass total with test_kb_lifecycle.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/e2e/test_pr35_pr36.pywith 4 tests that lock in the behaviour introduced by PRs #35 and #36.PR #35 — default search mode is now
hybrid(not hardcodedfts)handle_kb_searchinserver.pynow readsLORE_SEARCH_MODE_DEFAULT(default"hybrid") instead of hardcoding"fts". The response includesrequested_mode(intent, pre-degradation) andsearch_mode(executed mode).Tests added (
TestDefaultSearchMode):test_no_mode_requests_hybrid— nomodearg →requested_mode == "hybrid"test_explicit_fts_requests_fts—search_mode="fts"→requested_mode == "fts"test_explicit_hybrid_requests_hybrid—search_mode="hybrid"→requested_mode == "hybrid"PR #36 —
"summary"removed from search mode enumLiteral["summary"]was dropped fromserver_fastmcp.py'skb_searchsignature. Passing it must now surface as an MCP validation error.Tests added (
TestSummaryModeRemoved):test_summary_mode_raises—search_mode="summary"raisesLoreClientErrorTest results
Verified against lore-staging (CT 200,
http://localhost:5556):🤖 Generated with Claude Code