docs: issue #19 summary strategy + Pyright fixture annotation fix - #41
Closed
davidgut1982 wants to merge 3 commits into
Closed
docs: issue #19 summary strategy + Pyright fixture annotation fix#41davidgut1982 wants to merge 3 commits into
davidgut1982 wants to merge 3 commits into
Conversation
feat: e2e extraction eval harness + resilience fixes
…19) Removals: - Drop "summary" from strategy enum in _TOOL_DEFINITIONS (kb_ingest_doc, kb_ingest_dir) - Drop "summary" from Literal type in server_fastmcp.py (both kb_ingest_doc and kb_ingest_dir) Documentation: - Add "Why summary Strategy is Unsupported" section to DOCUMENT_INGESTION_GUIDE.md - Explains Lore is LLM-free, gives the correct caller-side pattern, and shows the invalid_input envelope callers receive if they pass strategy="summary" - Update the strategies bullet list to remove the stale "not yet implemented" note
The session_client, client, cleanup_topic, and slow_client fixtures use yield but were annotated with plain return types (LoreClient / str), triggering reportInvalidTypeForm/reportReturnType under Pyright. Annotate them as collections.abc.Iterator[...] so the generator return types type-check cleanly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/e2e/conftest.py: four yielding fixtures (session_client,client,cleanup_topic,slow_client) were annotated with plain return types, triggeringreportInvalidTypeForm/reportReturnType. They are now annotated ascollections.abc.Iterator[...].Pyright verification
Ran
pyrighton the affected files — 0 errors, 0 warnings:tests/e2e/conftest.pytests/e2e/test_search_modes.pysrc/lore/extraction/__init__.pyNotes on the original diagnostic report
The three issues described in the task brief did not match the codebase:
src/lore/extraction/filters.pyexists and is correctly imported by__init__.py(filter_turns,DEFAULT_MAX_TURNSare actively used). No change made.conftest.py, nottest_search_modes.py. Fixed there.test_search_modes.pyimportspytestnormally, already lives intests/e2e/, and has 0 Pyright errors. No new file was created.🤖 Generated with Claude Code