POC: Use ENV variables for configuration to allow for upgradability (and heroku support) #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I'm aware there's another issue open SquareSquash#33 however, I think the point has been lost amongst using jruby etc. None of that is required to get it running on heroku.
The few changes made have allowed me to
Using the following process to create the app.
I'm not happy with where the hacks are to use ENV variables at present. There are more configurations set during
setup.rb
to be extracted and perhaps modifying the setup itself. However, this approach:git pull && git push heroku
)I would use this in conjunction with a
.env
file (added to .gitignore) and instantiating those ENV variables before running the server withor using the
dot_env
gem.I would continue further here but the heroku File System concerns I've outlaid in SquareSquash#35 have pretty much stopped my progress. I'm not sure running on heroku will be possible without drastic changes to git repository integration.
Therefore, this is more a proof of concept but I thought I would document here as
a) using ENV variables would still be preferable, regardless of Heroku
b) if this information helps or inspires anyone else to get this running on Heroku 😃