⚡ Bolt: Optimize Qobuz secret verification short-circuiting#48
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
⚡ Bolt: Optimize Qobuz secret verification short-circuiting#48davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
Replaced `asyncio.gather` with `asyncio.as_completed` in `streamrip/client/qobuz.py` to short-circuit app secret checking, avoiding waiting for all concurrent API calls to finish once a valid secret is found. Co-authored-by: davidjuarezdev <230496599+davidjuarezdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Replaced
asyncio.gatherwithasyncio.as_completedand task cancellation in Qobuz's_get_valid_secretmethod.🎯 Why: Previously, the method tested all available app secrets concurrently but waited for all HTTP requests to complete before returning the first valid one. This caused unnecessary network requests, slow-tail latency, and background resource usage.
📊 Impact: Reduces time to check valid secrets by short-circuiting as soon as a successful API response is returned, reducing network overhead and login latency.
🔬 Measurement: Verify by running
poetry run pytest tests/test_qobuz_client.pyand noting the speedup in login time when multiple secrets are being tested.PR created automatically by Jules for task 4626234911601353803 started by @davidjuarezdev