⚡ Bolt: Offload mutagen synchronous file I/O to thread#49
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
⚡ Bolt: Offload mutagen synchronous file I/O to thread#49davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
Mutagen uses synchronous file I/O blocking the main asyncio loop. This commit moves the `get_mutagen_class` and `save_audio` operations to `asyncio.to_thread` preventing blocked concurrent downloads. Co-authored-by: davidjuarezdev <230496599+davidjuarezdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Wrap
mutagenfile load and save operations (container.get_mutagen_classandcontainer.save_audio) inawait asyncio.to_thread()within thetag_filefunction.🎯 Why: The
mutagenlibrary performs heavy, synchronous disk I/O when parsing and saving audio metadata tags. Inside thetag_fileasync function, executing these synchronously blocks the entireasyncioevent loop. This stall causes concurrent API requests and parallel media downloads to hang, drastically reducing the overall parallel download throughput of the application.📊 Impact: Significantly improves parallel downloading throughput. The main event loop is no longer stalled during the heavy I/O of loading/saving ID3 or FLAC picture tags on large media files, reducing concurrent tail latency.
🔬 Measurement: Benchmark concurrent downloads of an album with high-res cover art. The new threaded execution should show a reduced total download time with fewer stalls between parallel track downloads compared to synchronous tagging.
PR created automatically by Jules for task 1420421837364729949 started by @davidjuarezdev