⚡ Bolt: Wrap blocking PIL image operations in asyncio.to_thread#50
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
⚡ Bolt: Wrap blocking PIL image operations in asyncio.to_thread#50davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
…king Co-authored-by: davidjuarezdev <230496599+davidjuarezdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Wrapped the synchronous
downscale_imagefunction calls inawait asyncio.to_threadwithinstreamrip/media/artwork.py. This function uses thePIL.Imagelibrary for CPU/IO-bound processing (Image.open,image.resize,image.save).🎯 Why:
PIL.Imageoperations are synchronous and blocking. Calling them directly inside theasync def download_artworkfunction blocked the mainasyncioevent loop, causing performance bottlenecks and stalling other concurrent download tasks when processing high-resolution artwork or embedding multiple images.📊 Impact: Eliminates event loop stalls during artwork processing, significantly improving concurrent download performance when handling large albums or playlists.
🔬 Measurement: Verify by downloading an album with large artwork (
rip url ...with--config.artwork.embed trueand--config.artwork.save_artwork true) and monitoring CPU/asyncio execution flow.PR created automatically by Jules for task 11033434195393069513 started by @davidjuarezdev