🛡️ Sentinel: [CRITICAL] Fix SQL injection risk via assertion bypass#51
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
🛡️ Sentinel: [CRITICAL] Fix SQL injection risk via assertion bypass#51davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: davidjuarezdev <230496599+davidjuarezdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 Severity: CRITICAL
💡 Vulnerability: The
streamrip/db.pymodule relied on Python'sassertstatement to validate keyword argument keys against expected columns before unpacking them into dynamically constructed SQL queries in thecontains()method, and lacked validation entirely in theremove()method. Sinceassertstatements are stripped when Python is run with optimizations (-O), an attacker could supply malicious keyword argument keys (which bypass Python's strict identifier restrictions) leading to SQL injection.🎯 Impact: Potential for arbitrary code execution or data exposure via SQL injection if the application is run in optimized mode and processing untrusted input.
🔧 Fix: Replaced the
assertstatement with an explicitifstatement raisingValueErrorincontains(), and added the same explicit key validation toremove().✅ Verification: Ran
ruff checkandpytestto ensure no regressions. Added a Sentinel journal entry documenting the learning.PR created automatically by Jules for task 11038255197215758585 started by @davidjuarezdev