⚡ Bolt: Optimize Qobuz secret testing for faster login#59
Draft
davidjuarezdev wants to merge 1 commit intomainfrom
Draft
⚡ Bolt: Optimize Qobuz secret testing for faster login#59davidjuarezdev wants to merge 1 commit intomainfrom
davidjuarezdev wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: davidjuarezdev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Updated
_get_valid_secretinstreamrip/client/qobuz.pyto useasyncio.as_completedinstead ofasyncio.gather. Added task cancellation for remaining requests once a valid secret is found.🎯 Why: The previous implementation forced the application to wait for all secrets to be tested, which could include slow timeouts on invalid secrets, even if a valid secret was found quickly. This change short-circuits the wait.
📊 Impact: Reduces network I/O and significantly speeds up the login process by returning as soon as the first successful response is received. Prevents background task leakage.
🔬 Measurement: Verify by running tests (
PYTHONPATH=. poetry run pytest tests) and confirming Qobuz login is faster and successfully handles multiple secrets.PR created automatically by Jules for task 16929508269236089967 started by @davidjuarezdev