Open
Conversation
…ules CMake Modules
Also updated find package names at main to use proper case sensitivity required in Linux. The new Find*.cmake files are required at least in Fedora; other distros, and Mac OSX may have them system wide. Anyway this way they are always available.
Reverted some Find*.cmake packages and use system wide others, so that it compiles on Ubuntu 12.04 Precise, the one we have set at Travis. Works ok on CMake 3.5.2 too (Fedora 24).
…eferes to a directory.
…nd using pthread function declarations directly. From gc_config_macros.h and gc_pthread_redirects.h, the pthread function declarations are going to be automatically defined if not defined using macros making it cross compatible
…se 01-internal/18-listen_stop on darwin.
Fix: Takes another variable expected_result and sprintf the same format and the variable in it and check it with the onion_response_printf. Since both will follow the same implementation will give the same result if the test case works.
… name certtool while in Mac OSX it saves with name gnutls-certtool
altaiezior
force-pushed
the
darwin
branch
9 times, most recently
from
68cbf13 to
0a94ef4
Compare
Adds ./install-dependencies.sh to install dependencies needed for osx Make some other changes in .travis.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses S_ISDIR instead of DT_DIR
Adds missing header to resolve ssize_t not found problem
Corrects cairo example and typos in Boehm GC CMake Module
Replaces deprecated malloc.h with stdlib.h
Uses gnutls-certool instead of default certtool
Links external libraries properly
Includes CTest for making test cases and running them
Current Progress:
100% compilation on OSX system
TODO:
--help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning. MACOSX_RPATH is not specified for the following targets: i18n, onion, onioncpp
Test Cases Result:
Fixes Issues:
#119 #98
Help Needed:
In checking why the test cases might fail (with someone who has deeper insight of the code).