Open
Conversation
Owner
|
Hi! Thanks a lot for the patch, but although it makes the trick, I dont like too much that it actually do a half wrapper for openssl using gnutls functions (particularly the use of the headers with the defines). It hides whats really going on. I would prefer a openssl.c and a gnutls.c that implement the basic functions (basically whats on the defines and the extra headers), and make https.c call the proper implementation. |
Author
|
Hi! I know what you said. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ONION_USE_OPENSSL option to use OpenSSL instead of GnuTLS and GCrypt(default: false).
Tested on Ubuntu 16.10, OpenSSL 1.0.2g.