Open
Conversation
Reason for the change: The latest allocation of 'onion_response_last_date_header' in response.c will never free'd. Solution: Change 'onion_response_last_date_header' into static array and change strdup() by memcpy() call. Moreover, only one of the competing threads 'with a new header string' will overwrites 'onion_response_last_date_header'.
This string will hold a localized timestamp, but 200 seems too pessimistic?! (Multi-byte characters made it hard to estimate the lowest bound, but for the current strftime pattern all values > 64 seems big enough. )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #254 .
It just converts the storage for the date header into a fixed array. So, valgrind does not complain about the non-freed array at program end.
The change doesn't release us from using the locking around reading/writing the date_header.