fix(connect): fix connect not using server options correctly #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomSeeded
commented
Jun 6, 2018
| config.options.sslCA = Buffer.from(config.options.sslCA); | ||
| } | ||
|
|
||
| db = config.db || new MongoClient(); |
There was a problem hiding this comment.
|
@wzrdtales apologies for all the previous not-real PRs; I had been meaning to make them against my own fork and wasn't paying close enough attention. edit: looks like have tests to fix :( |
Signed-off-by: RandomSeeded <[email protected]>
RandomSeeded
force-pushed
the
nate/upstreamMerge
branch
from
4aa0126 to
5d3cee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RandomSeeded [email protected]