Skip to content

Add RequireAuth option for SMTP checks #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbaseqp merged 1 commit into from
Dec 19, 2025
Merged

Add RequireAuth option for SMTP checks #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions engine/checks/smtp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ import (

type Smtp struct {
Service
Encrypted bool
Domain string
Fortunes []string
Encrypted bool
Domain string
RequireAuth bool
Fortunes []string
}

type unencryptedAuth struct {
Expand Down Expand Up @@ -131,12 +132,15 @@ func (c Smtp) Run(teamID uint, teamIdentifier string, roundID uint, resultsChan

// Login
if len(c.CredLists) > 0 {
err = sconn.Auth(auth)
if err != nil {
checkResult.Error = "login failed for " + username + ":" + password
checkResult.Debug = err.Error()
response <- checkResult
return
authSupported, _ := sconn.Extension("AUTH")
if c.RequireAuth || authSupported {
err = sconn.Auth(auth)
if err != nil {
checkResult.Error = "login failed for " + username + ":" + password
checkResult.Debug = err.Error()
response <- checkResult
return
}
}
}

Expand Down